@cgrushko

heh, we didn't feel this internally because we have a blank line between the first line (comment) and the package statement :)
Can you add a test that makes sure that an existing blank line is preserved?

@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

heh, we didn't feel this internally because we have a blank line between the first line (comment) and the package statement :) Can you add a test that makes sure that an existing blank line is preserved?

Done

@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Apologies for the delay, everybody seems to be unavailable this week at the same time :(

Yeah, I know the feeling. Here too.

@cgrushko merged this pull request in b6e5f35.

Overall this looks like a good improvement.
In our tests to see what changes though, we found this regression.

With this change this code here, which should not be touched

// License

package /* comment */ com.example.ktfmt /* comment */

import com.example.ImportOne
import com.example.ImportTwo
// ...

Gets formatted to this – removing empty line separating package declaration and imports

// License

package /* comment */ com.example.ktfmt /* comment */
import com.example.ImportOne
import com.example.ImportTwo
// ...

Could you take a look into this?